Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPEX 046 v2: Particle extension #3

Merged
merged 17 commits into from
Nov 28, 2024

Conversation

AlexandreMinotCSI
Copy link
Contributor

SIDS, FMM and MLL doc in ReST site for CPEX 0046 - particle extension

@AlexandreMinotCSI
Copy link
Contributor Author

I would like to squash those commits, let me know if that's something that can be done from here of if I have to do it on my side.
Thanks

@MicK7
Copy link
Collaborator

MicK7 commented Jul 20, 2024

I would like to squash those commits, let me know if that's something that can be done from here of if I have to do it on my side. Thanks

The squash can be done from here during the merge but only one commit will remain.

@MicK7
Copy link
Collaborator

MicK7 commented Jul 20, 2024

LGTM. I will read it again before merging

@AlexandreMinotCSI
Copy link
Contributor Author

I can't figure out how to fix the check failure. Any ideas?

@brtnfld
Copy link
Member

brtnfld commented Aug 8, 2024

Add words to skip in .codespellrc

@AlexandreMinotCSI
Copy link
Contributor Author

Thanks for helping resolve the merge issues. Is this ready to be merged? Anything you need from us?

@brtnfld
Copy link
Member

brtnfld commented Aug 21, 2024

We're all set for now. After I finish updating the doxygen entries and pushing them to the new website, I'll review it. This will allow us to update the documentation along with the next CGNS release. The odds are that there will be many conflicts once my changes merge.

@AlexandreMinotCSI
Copy link
Contributor Author

Hi,
Is there a released date planned?
Thanks,
Alex

@brtnfld
Copy link
Member

brtnfld commented Nov 21, 2024

We are planning a release by the end of the year.

@brtnfld
Copy link
Member

brtnfld commented Nov 21, 2024

I'm in the process of transferring non-doxygen information from the midlevel/*html in PR #6. We no longer use these HTML files since they are now generated from Doxygen,

https://github.com/CGNS/cgns-modern.github.io/pull/6/files#diff-11e4acab6afe17691a724b6480b229eb97556f121f43c02993e0650808c123c7

These will have to be removed from your PR at some point. The other files that might have conflicts are the MLL/CGNS_MLL* files, which are no longer used.

@brtnfld
Copy link
Member

brtnfld commented Nov 27, 2024

@MicK7, I think this needs to be merged so that I can reference some of the documents in my PR. Do you see any reason not to merge it?

@brtnfld brtnfld requested a review from MicK7 November 27, 2024 17:33
@MicK7
Copy link
Collaborator

MicK7 commented Nov 28, 2024

@MicK7, I think this needs to be merged so that I can reference some of the documents in my PR. Do you see any reason not to merge it?

@brtnfld I don't see any reason not to merge it. Will you remove the MLL "html" files introduced by this PR in yours or should we remove them before merging ?

@MicK7
Copy link
Collaborator

MicK7 commented Nov 28, 2024

@MicK7, I think this needs to be merged so that I can reference some of the documents in my PR. Do you see any reason not to merge it?

@brtnfld I don't see any reason not to merge it. Will you remove the MLL "html" files introduced by this PR in yours or should we remove them before merging ?

Merging with the HMTL files. We will handle them afterward

@MicK7 MicK7 merged commit 1e39b2f into CGNS:doc-rest-migration Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants